Refactor tests #157
Open
Refactor tests #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbizon
requested changes
Dec 1, 2022
There was a problem hiding this comment.
Looks good, a few questions though
- Can you include some docs about how to run the tests? I think I need to fire up a redis or?
- Does this address /get_semantic_types endpoint is not working #153 ? I saw a test that indicated that perhaps it does
- It looks like this includes some new conflation abilities. Can you add some doc somewhere about what is required to add more of these? I think this is something we're going to do multiple times in the next year
- I think that there's a mismatch in startup/shutdown in server with the number of redis connections (we close 7 but open 6)
|
It does address #153 as I refactored loader.py. I will update the docs. |
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of changes in this branch, but mostly contains a refactor of the tests to leverage testcontainers more thoroughly. I also split the code for loading compendia & conflation files into independent CLI apps.